Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

希望 SDK 相关 API 都可以支持 context.Context #73

Open
shuqingzai opened this issue Aug 16, 2024 · 1 comment
Open

希望 SDK 相关 API 都可以支持 context.Context #73

shuqingzai opened this issue Aug 16, 2024 · 1 comment

Comments

@shuqingzai
Copy link

目前所有接口都不支持 context,只支持 timeout,使用起来非常不友好。

  1. 对于上游的调用无法准确知道超时时间,期望能在上游 cancel 后能同时 cancel 这次 SDK 的接口请求
  2. 对于链接追踪可以控制 request trace ,比如: OpenTelemetry ,也期望可以做到内置支持 OpenTelemetry 集成
  3. 也许可在 runtime.RuntimeOptions 做参数配置??
@RyoJerryYu
Copy link

同意, AWS 的 SDK 里已经能很方便地接入 otel : https://github.com/open-telemetry/opentelemetry-go-contrib/blob/e6e7902d104cb633154df760add009a5a0c2d5a3/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/example/main.go#L56-L57

现在阿里云 SDK 接入 otel 只能入侵业务代码,希望阿里云的 SDK 也能提供类似方法使用 context 及接入 otel 。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants