-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API reference and APIClient
docs could be improved
#587
Comments
Thanks for pointing this out @DavidSonoda. *_ex APIs are intended for use by ClearML's UI implementation - They are considered a volatile interface with no guarantee for functional specification or backwards compatibility, and as such their use is discouraged.
Though having no direct impact on APIClient (which is a client side release), this is a great idea which is indeed on our todo list.
The APIClient is intended for automation of tasks that the python package handles, and as such the endpoints implemented would be ones for APIs used by that package (Notice it is provided as part of clearml/clearml-agent, and not the server repo - It makes no guarantee to encompass the entire backend API). The ClearML Server is fully backwards compatible, so it will support any version of APIClient (Which, naturally, will implement APIs of the server version available at the time of its release). That said, we can certainly look into clarifying which APIs are supported by an APIClient implementation. |
Thank you so much for the reply.
The reason why I used However, generally speaking I think the APIs are really well designed and straight forward to use. Thanks for all the work. |
Hi,
I've been writing some simple utilities with clearml and found some inconsistencies between the Server API reference and the
APIClient
provided by the python SDK. Although the Server API Reference is documenting the HTTP APIs, not all APIs are available from theAPIClient
. However, in theAPIClient
section of the documentation, it does not mention about supported API endpoints. This creates confusions. For example:I needed to fetch the queues and their connected workers using the
APIClient
, then I found this API:queues.get_all_ex()
However, calling this from the python SDK will throw the following error:
I've checked the source code, seems like the
queues.get_all_ex()
is not implemented yet. I think mentioning this in theAPIClient
/Server API reference documentation would greatly improve the clarity of the docs and reduce confusion.To do that, I got some thoughts:
clearml
SDK versions could be listed, whoseAPIClient
will support the version of the Server API.Forgive me If my suggestion will break the current implementation of the docs, as I noticed the API references are auto generated according to the code. So my thoughts are by no means the best since I have no idea how much work is needed to do that.
Thanks.
The text was updated successfully, but these errors were encountered: