feature: Open Sans font files #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShrimpCryptid
commented
Apr 12, 2024
There was a problem hiding this comment.
Added additional fallbacks for other languages and emojis. I don't expect these other fonts to be used, but it's good to include just in case!
There was a problem hiding this comment.
Fallback fonts copied from the parent app, which I think is currently provided by Ant.
ShrimpCryptid
requested review from
blairlyons,
ascibisz and
meganrm
and removed request for
a team and
ascibisz
Closed
meganrm
approved these changes
Apr 15, 2024
blairlyons
approved these changes
Apr 16, 2024
ShrimpCryptid
changed the base branch from
feature/landing-page-styling
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimated review size: small, 10 minutes
Removes the Merriweather Sans and Overpass font files and replaces them with Open Sans. This change ensures that the viewer looks the same even when embedded!
We are importing Open Sans from Google Fonts, which means that it should work in almost all browser contexts. For full compatibility with older browsers, however, we need to include the WOFF, WOFF2, TTF, EOT, and SVG file formats. (https://css-tricks.com/snippets/css/using-font-face-in-css/#h-deepest-possible-browser-support)
Google Fonts will also not work in contexts without internet access, so having these fonts embedded in the project ensures that the viewer will look consistent.
There are some super minor differences between the fonts included (500 vs. 600 weight on the semibold) but otherwise they should look identical.