feature: Landing page loading (merge into main) #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-landing-page - Adds `react-router-dom` and routes for the landing page (at root URL, `/`) and viewer (`/viewer`). - The landing page can now redirect to the viewer when a Load button is clicked, and passes the app arguments as state through the navigation API. - Renamed the `landing-page` directory to `website`, since it now includes several website-related components. - Adds a new `AppWrapper` component, which wraps `ImageViewerApp`. - Handles retrieving app arguments from URL or from routing. - Moves the URL parsing logic to `url_utils.tsx`.
toloudis
approved these changes
Apr 23, 2024
frasercl
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that branches don't get auto-deleted in this repo so the landing page loading PR didn't get automatically updated to merge into main.
This is a follow-up PR to correctly merge into main.
Commit history should be the same as this PR: #212