Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSDP optimizations to try #289

Closed
4 tasks done
epwalsh opened this issue Sep 26, 2023 · 0 comments · Fixed by #340
Closed
4 tasks done

FSDP optimizations to try #289

epwalsh opened this issue Sep 26, 2023 · 0 comments · Fixed by #340
Assignees
Labels
project/model Related to modeling decisions and implementations

Comments

@epwalsh
Copy link
Member

epwalsh commented Sep 26, 2023

We should see what the perf impact of this all of these changes are.

  • All-reduce in FP32. Reduce gradients in fp32 #291
  • We might not need the autocast() context manager due to FSDP native mixed precision. We should try without it. This is good by default because it forces certain ops to run in FP32, like CE loss.
  • Try different wrapping strategies, like wrapping groups of OlmoBlocks together. This would require refactoring the model a a little bit to make it possible to group more than one blocks together. Add option to FSDP wrap by groups of blocks #340
  • Store buffers in FP32. This would make the alibi or rope buffers be full precision, which we might want. We're not actually using buffers, so this doesn't affect us.
@epwalsh epwalsh added the project/model Related to modeling decisions and implementations label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project/model Related to modeling decisions and implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant