Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P3] Create Constants for Magic Numbers #115

Open
jonryser opened this issue Dec 14, 2024 · 0 comments
Open

[P3] Create Constants for Magic Numbers #115

jonryser opened this issue Dec 14, 2024 · 0 comments

Comments

@jonryser
Copy link
Collaborator

Magic Numbers
Example: 8 for historyLimit, 2048 for maxTokenCount, and 1_000_000_000 / 2 for loop delay are hardcoded.
Suggestion: Replace with constants or configurable parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonryser