Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

Make a PersistedProducer interface #17

Open
schmmd opened this issue Mar 13, 2015 · 1 comment
Open

Make a PersistedProducer interface #17

schmmd opened this issue Mar 13, 2015 · 1 comment

Comments

@schmmd
Copy link
Member

schmmd commented Mar 13, 2015

In src/main/scala/org/allenai/pipeline/Producer.scala:

> @@ -125,7 +156,7 @@ trait CachingDisabled extends CachingEnabled {
>    override def cachingEnabled: Boolean = false
>  }
>  
> -class PersistedProducer[T, -A <: Artifact](
> +class PersistedProducer[T, -A <: Artifact] private[pipeline] (

The Producer.persist method returns a PersistedProducer not a simple Producer This really should be changed to return an interface instead of a concrete class. The only additional thing that PersistedProducer exposes is the Artifact that the data was saved to.

@rodneykinney
Copy link
Member

I'm addressing this in the branch I'm using to build out some needed functionality exposed by the integration of DBLP matching.

https://github.com/rodneykinney/pipeline/blob/artifact-factory/src/main/scala/org/allenai/pipeline/Producer.scala#L146

This was referenced Jun 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants