-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to ensure the robot's horizon is in a valid range? #30
Comments
Hi @Roadsong,
import ai2thor.controller import Controller
c = Controller(
commit_id="bad5bc2b250615cb766ffb45d455c211329af17e",
rotateStepDegrees=30,
visibilityDistance=1.0,
gridSize=0.25,
agentType="stochastic",
continuousMode=True,
snapToGrid=False,
agentMode="locobot",
fieldOfView=63.453048374758716,
width=640,
height=480
)
c.reset("FloorPlan_Train1_1")
print(c.last_event.metadata["agent"]["cameraHorizon"], c.last_event.metadata["lastActionSuccess"])
# 0.0 True
c.step("LookDown")
print(c.last_event.metadata["agent"]["cameraHorizon"], c.last_event.metadata["lastActionSuccess"])
# 30 True
c.step("LookDown")
print(c.last_event.metadata["agent"]["cameraHorizon"], c.last_event.metadata["lastActionSuccess"])
# 30 False
for _ in range(3):
c.step("LookUp")
print(c.last_event.metadata["agent"]["cameraHorizon"], c.last_event.metadata["lastActionSuccess"])
# 0 True
# -30 True
# -30 False So looking up and down will not allow the agent to look beyond the -30 to 30 range. Note that this is only true for this particular version of the AI2-THOR build (build |
Thanks for your quick and detailed response, really appreciate it! |
Hi @Lucaweihs I have another quick question: I noticed that in your initialization of locobot robot, the filed of view is set to According to the paper: https://arxiv.org/pdf/2006.13171.pdf section "sensor specification", the filed of view should be set to |
Hi @Roadsong, 63.453048374758716 is the vertical FOV, as we're using 4:3 aspect ratio this translates to a horizontal FOV of 79. Here's some code that does this conversion in case you're interested. Regarding resolution: yes that's right, feel free to use a smaller resolution if you'd prefer though (so long as you keep the same aspect ratio!) as this can be faster to train and use less memory (I believe we render at 300x400 and then resize to 224x224 before passing images to a pretrained cnn). |
Hi guys, I was playing robothor ObjNav tasks recently and it was really interesting! Thanks for your great work!
I have a few questions about the actions of the robot:
I checked out the example_submission file and found that the "success" of an "Stop" action can be either be true of false. Why the simple "Stop" action can produce both true or false outcomes? Does the success of the "Stop" action indicate the final success of the entire trajectory? I don't really think so because I also noticed that when "Stop"'s "success" is false, the final result is guaranteed to be false. However, when "Stop"'s "success" is true, still the final results can be false.
How to guarantee the horizons of the robot are in the valid range? I am aware that the expected horizon for locobot is {-30, 0, +30}, as stated in the documentation. But, how to ensure when the horizon is 30, another "LookDown" will not performed? Or those actions are deemed invalid and will not be executed? I mean, I realized that the horizon of 60, or -60 are possible, I just want to know how to ensure they are not exist in the submissions, thanks in advance!
The text was updated successfully, but these errors were encountered: