-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration overhaul #2
Comments
There is config object now but I think there are still some things to look into:
|
I think the bands / layer type is fine and JSON is okay too but we should use jsonargparse for parsing the configuration. #104 uses jsonargparse to parse the tile store portion of the dataset config, maybe that can be a model to gradually switch to jsonargparse for other components. We will need to decide whether we want to instantiate the data source objects though. It can be slow for some data sources. Maybe the client/bucket should be created when needed rather than during instantiation. |
Figure out how configuration files and loading config from them should work.
Right now some configuration loads arguments to a constructor directly (e.g. loading data source), while others have dedicated parsing functions.
Look into best practices but I think sticking with a function to parse the configuration into a class is good.
Dataset should store config as DatasetConfig or similar rather than keeping the decoded JSON dict.
The text was updated successfully, but these errors were encountered: