Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ES_WP_Query::query_es() to return a WP_Error #71

Open
mboynes opened this issue Jul 16, 2018 · 0 comments
Open

Allow ES_WP_Query::query_es() to return a WP_Error #71

mboynes opened this issue Jul 16, 2018 · 0 comments

Comments

@mboynes
Copy link
Contributor

mboynes commented Jul 16, 2018

If ES_WP_Query::query_es() (in an adapter) encounters an error, it should be able to communicate that to the wrapper. As of now, doing so wouldn't cause any issues due to proper return value validation, but it would be good to explicitly catch errors in the wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant