Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moveit controller #10

Merged
merged 16 commits into from
Nov 11, 2024
Merged

Moveit controller #10

merged 16 commits into from
Nov 11, 2024

Conversation

Jelmerdw
Copy link
Collaborator

@Jelmerdw Jelmerdw commented Nov 4, 2024

This PR adds:

  • A Moveit controller as an Action service. This enables the code-wise use of Moveit using action calls, with a PoseStamped message as input.
  • A Rviz controller as Service. This enables spawning and clearing of markers in Rviz. More features can be added in the future.
  • A separate package (rcdt_utiltities_msgs) for custom message used by different nodes in the rcdt_utilities package.

How to use/test?

One can test these new features (in combination with this PR in rcdt_franka) by running:

ros2 launch rcdt_franka franka.launch.py moveit:=node rviz:=True

By selecting the new option node for the moveit flag, the moveit_controller node will be started. One can move the robot using an Action call, for example:

ros2 action send_goal --feedback /moveit_controller rcdt_utilities_msgs/action/Moveit "{goal_pose: {header: {frame_id: fr3_link0}, pose: {position: {x: 0.28, y: 0.2, z: 0.5}, orientation: {x: 1.0, y: 0.0, z: 0.0, w: 0.0}}}}"

Currently, the Action will also publish a marker in Rviz for the goal_pose, if the new rviz_controller node is running. This node needs to be started manually:

ros2 run rcdt_utilities rviz_controller_node

If this node is not started, the moveit Action service should still work, but show a warning that publish of the Rviz marker is not possible.

Real robot:

This is also tested on the new robot. A better specification of acceleration limits was required. For more info, see the related PR for rcdt_franka:

alliander-opensource/rcdt_franka#7

Copy link
Collaborator

@WPDOrdina WPDOrdina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heel mooi werk, een paar opmerkingen.

Nog een extra: momenteel moet er een extra node handmatig op worden gestart om de target te zien in rviz. Het zou fijn zijn als die automatisch mee wordt gelanceerd als rviz zelf ook gelanceerd wordt. Waarom heb je ervoor gekozen dat niet te doen?

rcdt_utilities/launch/moveit.launch.py Outdated Show resolved Hide resolved
rcdt_utilities/launch/moveit.launch.py Outdated Show resolved Hide resolved
rcdt_utilities/launch/moveit.launch.py Outdated Show resolved Hide resolved
rcdt_utilities/launch/moveit.launch.py Outdated Show resolved Hide resolved
rcdt_utilities/launch/rviz.launch.py Show resolved Hide resolved
rcdt_utilities/nodes/moveit_controller_node.py Outdated Show resolved Hide resolved
rcdt_utilities/nodes/moveit_controller_node.py Outdated Show resolved Hide resolved
rcdt_utilities/nodes/moveit_controller_node.py Outdated Show resolved Hide resolved
rcdt_utilities/nodes/moveit_controller_node.py Outdated Show resolved Hide resolved
@Jelmerdw Jelmerdw merged commit 3aa1881 into main Nov 11, 2024
3 checks passed
@Jelmerdw Jelmerdw deleted the moveit_controller branch November 11, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants