-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moveit controller #10
Conversation
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heel mooi werk, een paar opmerkingen.
Nog een extra: momenteel moet er een extra node handmatig op worden gestart om de target te zien in rviz. Het zou fijn zijn als die automatisch mee wordt gelanceerd als rviz zelf ook gelanceerd wordt. Waarom heb je ervoor gekozen dat niet te doen?
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
This PR adds:
How to use/test?
One can test these new features (in combination with this PR in rcdt_franka) by running:
ros2 launch rcdt_franka franka.launch.py moveit:=node rviz:=True
By selecting the new option node for the moveit flag, the moveit_controller node will be started. One can move the robot using an Action call, for example:
ros2 action send_goal --feedback /moveit_controller rcdt_utilities_msgs/action/Moveit "{goal_pose: {header: {frame_id: fr3_link0}, pose: {position: {x: 0.28, y: 0.2, z: 0.5}, orientation: {x: 1.0, y: 0.0, z: 0.0, w: 0.0}}}}"
Currently, the Action will also publish a marker in Rviz for the goal_pose, if the new rviz_controller node is running. This node needs to be started manually:
ros2 run rcdt_utilities rviz_controller_node
If this node is not started, the moveit Action service should still work, but show a warning that publish of the Rviz marker is not possible.
Real robot:
This is also tested on the new robot. A better specification of acceleration limits was required. For more info, see the related PR for rcdt_franka:
alliander-opensource/rcdt_franka#7