Remove the indentation warning. #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the early days of AMX Mod X/SourceMod there weren't really good
source editors. Many people used Notepad for their scripting. Mixing
tabs/spaces and getting indents wrong was very common.
These days there are a few factors that make this less critical:
- There are many high quality editors available, and there is much
more awareness around them.
- The industry has basically settled on spaces for indentation.
- Modern programming languages tend to come with auto-formatting tools now as
well, which is probably something SourcePawn should do.
Either way, the inline linter is a huge, huge hack and has no business
being right there in the lexer. It makes token caching very complex.
It's slow. And it requires knowing a predefined value for tabsizes,
which makes no sense.
So awaaaay it goes.
|
Purge the unclean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the early days of AMX Mod X/SourceMod there weren't really good
source editors. Many people used Notepad for their scripting. Mixing
tabs/spaces and getting indents wrong was very common.
These days there are a few factors that make this less critical:
more awareness around them.
well, which is probably something SourcePawn should do.
Either way, the inline linter is a huge, huge hack and has no business
being right there in the lexer. It makes token caching very complex.
It's slow. And it requires knowing a predefined value for tabsizes,
which makes no sense.
So awaaaay it goes.