Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mode: Ask if no rule applies #40

Closed
mahoromax opened this issue Sep 9, 2023 · 12 comments
Closed

Mode: Ask if no rule applies #40

mahoromax opened this issue Sep 9, 2023 · 12 comments
Milestone
4.0.2

Comments

@mahoromax
Copy link

Hi, I believe this is easy to adapt and it really would fit the "learning" behaviour of it.

-> URL that doesn't fit any rule? -> Ask and add rule
-> URL that should always be asked -> Ask and do not add a rule
@aloneguid
Copy link
Owner

I assume you have tried this and it doesn't work for you?
image

I like the idea of adding rules that must always trigger the picker!

@mahoromax
Copy link
Author

Yes, when there is no conflict or no rule it just opens the default browser...
And I'm not sure how to make rules that apply to everything - except stuff already handled by other rules...

@adynis
Copy link

adynis commented Dec 14, 2023

I also would like to have an option that shows the "Picker" by default (when no rule apply) , and the selecgted browser when one rule matches.
It's not very clear to me what "Conflict" means on "Ask on Conflict" , but I would see very usefull an additional option there like: "Ask when no rule"

@aloneguid
Copy link
Owner

I appreciate your feedback, it's very helpful. I agree that "ask on conflict" is not a clear or common option - it only pops up a dialog when there are multiple browsers/profiles that can open a certain URL. I think you're right that I should add another option like you suggested - "Ask when no rule matched". That would make it easier for users to choose the browser/profile they want when there is no rule defined. How does that sound?

@Mythrix
Copy link

Mythrix commented Feb 28, 2024

I would also like an option like "Ask when no rule matched" in any case.

I used to use BrowserSelect which worked like that: Pop up the option to select a browser for all URLs, but if a rule is found, it will autopick the browser. (I switched away from that tool because it tended to add duplicate copies of each browser in the list when refreshing browsers, which got annoying after it happened a few times.)

Although now I decided to try using the "Also open on" feature in combination with "Ask on conflict" in BrowserTamer. Which does kinda solve my use case, as long as I remember to hold down the keyboard shortcut when clicking on links.

@Mythrix
Copy link

Mythrix commented Jun 24, 2024

PS: I almost never remembered to hold down the shortcut keys when clicking on links. Additionally, holding down the keys would mess with some apps (specifically Outlook tends to act weirdly when I hold down certain keys and try to click.) So that did not really work out at all...

In the end I tried out other alternatives, but many did not support browser profiles well. Eventually I got to Switchbar which supports both "Ask if no rule applies" and browsers with multiple profiles. So other people with the same issue could consider trying that option. Do note that Switchbar has a free and a paid version, and the free version only supports 2 "favorite" browsers/profiles (but for me that was enough, for now at least.)

In any case, it would be great if BT could also get the option to show the picker only when no rules are matching.

@aloneguid
Copy link
Owner

aloneguid commented Jun 24, 2024 •
edited
Loading

If everyone paid £16 like Switchbar asks I think I could probably find time to implement this very quickly :) On a serious note yes, this is planned, but I don't know when as I'm busy implementing other features. It should be withing next few months though.

P.S. This app is opensource, so anyone can try doing it themselves.

@aloneguid
Copy link
Owner

This will be coming in v4, something like this:

@aloneguid
Copy link
Owner

done

@Mythrix
Copy link

Mythrix commented Jul 17, 2024

Hi, thanks for your hard work!

Unfortunately I was unable to get the "On no rule" option to work properly. In fact, it is possible that even the "On conflict" option does not work anymore in v4.

I have tried:

  • Using only the "On no rule" option
    • This just opens in the default browser (unless there's a rule in effect)
  • Using just the "On conflict" option
    • Same as above, additionally even if there is a conflict, it just opens up in the first(?) browser that has the rule
  • Using both the "On no rule" and "On conflict" options
    • Same as above
  • Deleting (renaming) config.ini to get a completely "fresh" BT configuration
    • Did not seem to help
  • Uninstalling v4 and reinstalling v4 again
    • Did not seem to help
  • Also rolled back to v3.7.3 to doublecheck
    • "On conflict" seems to wwork properly there

This is on a Windows 10 22H2 PC.

Do not worry about prioritizing this bug in any case, I can understand that it's hard to take time for an opensource hobby project. And I hope it's not just me doing something wrong in my settings/usage...

@aloneguid aloneguid reopened this Jul 18, 2024
@aloneguid
Copy link
Owner

Yes you're right, that slipped in. Hope to fix this today!

aloneguid added a commit that referenced this issue Jul 18, 2024
@aloneguid
Refactor bt.cpp & update build to 4.0.2
4c83c89 
- Updated the build version in `build.yml` from `4.0.1` to `4.0.2`.
- In `bt.cpp`, refactored the picker logic to use a structured decision-making process. This includes handling conditions like `force_picker`, `picker_always`, `picker_on_conflict`, and `picker_on_no_rule`. Added `pick_reason` to improve logging and decision transparency.
- Updated the subproject commit in `common` to include changes up to a new commit marked as `-dirty`.
- Added release notes for version `4.0.2` in `release-notes.md`, highlighting the bug fix for picker visibility issues, credited to @Mythrix for their contribution in resolving issue `#40`.
@Mythrix
Copy link

Mythrix commented Jul 19, 2024

Thanks for the quick fix!
I tested a little bit now, and both "On no rule" and "On conflict" seems to work properly now.
And the integration with Firefox containers also seem to work great when using the rules!
👍

@aloneguid aloneguid added this to the 4.0.2 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.2
Development

No branches or pull requests
4 participants
@aloneguid @Mythrix @adynis @mahoromax