Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle multi-line comments #2

Open
yurrriq opened this issue Dec 13, 2016 · 4 comments
Open

Properly handle multi-line comments #2

yurrriq opened this issue Dec 13, 2016 · 4 comments

Comments

@yurrriq
Copy link
Contributor

yurrriq commented Dec 13, 2016

Broken implementation:

(,(rx (group "{-") (group (* anything)) (group "-}"))
 (1 font-lock-comment-delimiter-face)
 (2 font-lock-comment-face)
 (3 font-lock-comment-delimiter-face))
@tjweir
Copy link
Contributor

tjweir commented Dec 13, 2016

Given the similarity to Haskell comments, I think we should be able to learn from their handling of {- ... -}

@yurrriq
Copy link
Contributor Author

yurrriq commented Dec 13, 2016

Yeah, I glanced at it and it looks like they use syntax tables. I think we'll need to dig into them for indentation handling too.

@tjweir
Copy link
Contributor

tjweir commented Dec 13, 2016

Yes, I started looking into syntax tables for this, I don't know much right now.

@yurrriq
Copy link
Contributor Author

yurrriq commented Dec 13, 2016

Same...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants