From c7995df49c7644240378f2908675b7c6c80f1fb3 Mon Sep 17 00:00:00 2001 From: Russell Garner Date: Fri, 17 Nov 2023 12:02:38 +0000 Subject: [PATCH] Add known compatible Python/Node dev versions Also update CONTRIBUTING.md to match. For contribution, add versions we know to work together. @wdio/sync brings fibers, which needs compilation. That compilation fails for some combinations of Node and Python: ``` ValueError: invalid mode: 'rU' while trying to load binding.gyp ``` or ``` npm ERR! ../src/fibers.cc:27:65: error: no member named 'kFinalizer' in 'v8::WeakCallbackType' npm ERR! handle.SetWeak(val, WeakCallbackShim, WeakCallbackType::kFinalizer); npm ERR! ~~~~~~~~~~~~~~~~~~^ ``` Fixes #608. --- .nvmrc | 2 +- CONTRIBUTING.md | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.nvmrc b/.nvmrc index ed9f5a0a..518633e1 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -14.18.2 +lts/fermium diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d7300cc3..ed2ee389 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,13 +6,13 @@ If you want to help and want to get more familiar with the codebase, try startin ## Requirements -You will need a recent version of Node and npm installed: +You will need a recent version of Node and npm installed. Check the `.nvmrc` for a recommended version: ```bash $ node -v -v7.10.0 +v14.21.3 $ npm -v -v5.0.0 +v6.14.18 ``` If you want to run the selenium tests, you will also need a local copy of the Java Development Kit: @@ -24,10 +24,12 @@ Java(TM) SE Runtime Environment (build 1.8.0_131-b11) Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode) ``` -To install Node (with npm) and Java locally on macOS, you can use [brew](https://brew.sh/): +To install Node (with npm) and Java locally on macOS, we recommend [brew](https://brew.sh) with +[nvm](https://github.com/nvm-sh/nvm): ```bash -brew install node +brew install nvm +nvm install brew cask install java ```