Upgrade to govuk frontend 5.1 #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
1fcb0a3
to
4700fba
Compare
Closed
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
4700fba
to
339a982
Compare
MartinJJones
changed the title
hannalaakso
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Changes look good to me 👍 I've looked at both the code changes and run the app locally to check there are no errors on a selection of pages.
As discussed with Martin, I'm commenting instead of approving as we still have some failing tests on the PR. Once the new gem is released, these tests should pass and the PR can be approved at that point.
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
339a982
to
eb6b76b
Compare
To prevent browsers evaluating JS that isn't supported, components that contain code from govuk-frontend have been moved to a separate file `es6-components.js` which is included in `application.html.erb` as a script tag with `type="module"`
Remove $legacy attribute in govuk-colour, this is no longer supported from v5 of govuk-frontend
Updated to continue to use the closest Polyfill from v4 of govuk-frontend which is now included in the publishing_components_gem
hannalaakso
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
eb6b76b
to
830181d
Compare
hannalaakso
changed the title
hannalaakso
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
es6-components.jsfileWhy
Move components that rely on govuk-frontend modules to seperate
es6-components.jsfileIn the event that a browser below the target for
govuk-frontendloads a page with JS on it, attempting to parse the JS fromgovuk-frontendwill cause an error. To avoid this from happening, JS that containsgovuk-frontendJS has been moved to seperate file which will be loaded in a script tag withtype="module". This will prevent the JS from being parsed and so prevent the errorRemove Sass variables
$legacyattribute ingovuk-colourhas been deprecated and using it will have no effect (other than generating warnings on pre-compilation)Update polyfill file paths
Browser polyfills are no longer included in v5 of govuk-frontend, any Polyfills provided in v4 of govuk-frontend will be included in the new version of the govuk-publishing-components gem.
The intention is for this PR to include the bump to the govuk-frontend v5 version of the govuk-publishing-components gem, this will also fix the failing tests relating to the missing polyfill.
Trello
Follow these steps if you are doing a Rails upgrade.