Fix breadcrumbs WCAG problem in the covid page #3763
Conversation
unoduetre
changed the title
unoduetre
force-pushed
the
2822-fix-breadcrumbs-wcag-fail-in-collections-s-m
branch
from
30ade10
to
2c46495
Compare
unoduetre
force-pushed
the
2822-fix-breadcrumbs-wcag-fail-in-collections-s-m
branch
from
2c46495
to
fd9b5bf
Compare
| color: govuk-colour("white"); | ||
|
|
There was a problem hiding this comment.
Doing it in a similar way to how it's done for /browse pages.
| @@ -15,27 +15,40 @@ $c19-landing-page-header-background: govuk-colour("blue"); | |||
|
|
|||
| .global-bar-present { | |||
| @include govuk-media-query($from: desktop) { | |||
| .covid__page-header { | |||
| .covid__breadcrumb-wrapper { | |||
There was a problem hiding this comment.
Do we think that these three renamed classes are still being used? Their parent is something called .global-bar-present but there doesn't seem to be
.global-bar-present on the page or in the app.
There was a problem hiding this comment.
I didn't change anything just to stay safe, but I also don't think .global-bar-present is still used, so I'm happy to remove this part. It's also used in browse pages, so I can also remove it from there. Please, let me know, if that's ok?
There was a problem hiding this comment.
I dug into this and realised this for the global banner coming from static: https://docs.publishing.service.gov.uk/manual/global-banner.html#activate-the-global-banner It might be good to double check that these styles work if the global banner is there although I think it's been a bit waffy to test with the global banner in the past since it's in static 🤔
There was a problem hiding this comment.
I'll test it with a global banner enabled in static.
There was a problem hiding this comment.
I've just had a look at integration/coronavirus and it looks good to me with the global banner enabled 👍 I'm going to approve the PR but let me know if there was something else about the global banner I should be checking.
There was a problem hiding this comment.
That's all I think.
unoduetre
force-pushed
the
2822-fix-breadcrumbs-wcag-fail-in-collections-s-m
branch
from
fd9b5bf
to
97385e7
Compare
unoduetre
deleted the
2822-fix-breadcrumbs-wcag-fail-in-collections-s-m
branch
Follow these steps if you are doing a Rails upgrade.
What
collections places breadcrumbs inside the
container in app/views/coronavirus_landing_page/components/landing_page/_page_header.html.erb, creating a WCAG fail on the covid landing page.Why
Having the breadcrumbs inside the main container is a WCAG fail.
Trello ticket