Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review attachment-link component usage #3483

Open
MartinJJones opened this issue Jul 6, 2023 · 2 comments · May be fixed by alphagov/government-frontend#3468
Open

Review attachment-link component usage #3483

MartinJJones opened this issue Jul 6, 2023 · 2 comments · May be fixed by alphagov/government-frontend#3468
Labels
design Design inconsistencies and quirks

Comments

@MartinJJones
Copy link
Contributor

MartinJJones commented Jul 6, 2023 •
edited
Loading

What

Replace the download-link component used in government-frontend with the attachment-link from the publishing components gem.

Download Link - https://govuk-government-frontend.herokuapp.com/component-guide/download_link
Attachment Link - https://components.publishing.service.gov.uk/component-guide/attachment_link/with_data_attributes/preview

Why

The style for the download-link component is very different to the attachment-link component as shown in the screenshots below. Not only because of the bold text, but the download-link component also includes an SVG icon to the left of the link. The icon itself does not appear to best represent a download action, but instead would likely indicate a copy action.

Material Design - Content Copy icon - https://materialui.co/icon/content-copy
Font Awesome - Copy icon - https://fontawesome.com/icons/copy?f=classic&s=solid

Screenshot comparison

Publishing component - attachment-link Government Frontend - download-link
attachment-link-gem government-frontend-download-link

Example page: https://www.gov.uk/foreign-travel-advice/algeria
@MartinJJones MartinJJones added the design Design inconsistencies and quirks label Jul 6, 2023
@nnagewad
Copy link

nnagewad commented Jun 7, 2024

@MartinJJones this may be a silly question but will this continue to be an issue once app consolidation is underway?

@MartinJJones
Copy link
Contributor Author

MartinJJones commented Jun 7, 2024 •
edited
Loading

@MartinJJones this may be a silly question but will this continue to be an issue once app consolidation is underway?

Good question, I'm not too familiar with the app consolidation work, but I think it would depend on the approach used, for example, you could lift and shift the download-link from one application into another. In this scenario the app would be consolidated, but the attachment/download link component variations could still exist.

I imagine that by using components from the gem and consolidating the components, it could potentially make the consolidation work a bit easier, from a frontend perspective at least, no HTML, CSS or JS to migrate over to the other application for example.

@jon-kirwan jon-kirwan linked a pull request Dec 9, 2024 that will close this issue
Open
@jon-kirwan jon-kirwan linked a pull request Dec 9, 2024 that will close this issue
Remove the download link component alphagov/government-frontend#3468
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Design inconsistencies and quirks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the download link component alphagov/government-frontend
2 participants
@nnagewad @MartinJJones