-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Percy's target branch to the PR base [v4.x] #4180
Conversation
The Percy changes seem good. The disappearance of margin above the header/footer examples would be consistent with the removal of the main wrapper from the examples. 👍 There's a tiny change on the select component where it appears to have become a couple of pixels narrower between different versions of Edge, but as there's no change in Firefox I would assume this change is not a result of changes to our code. |
Modify GitHub actions config so that Percy runs comparisons with the PR's target branch as the base, rather than always using 'main'.
9be924b
to
87b6670
Compare
a469611
to
97838f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great in a manual run too? Let's do it
@colinrotherham From what I can gather there isn't an obvious way of making this work in manual runs without hardcoding the branch name. GitHub Actions always defaults to using Choosing from the "Use workflow from" dropdown in the Actions interface only changes what branch is compared against I've merged on the basis that the last commit to this branch seemed to produce the expected comparisons in Percy: https://percy.io/55ba5e1a/govuk-frontend/builds/29991587/ |
Modify GitHub actions config so that Percy runs comparisons against the PR's base branch rather than always using
main
.This is particularly needed on the v4 support branch as
main
has diverged quite significantly, however we still intend to make v4 releases and want visual regression tests to work as expected.