Date input component should allow errors on individual text inputs, e.g. just the day field #3510
Comments
|
Hi @floehopper, apologies for taking a while to respond. Thanks for submitting the issue. If you'd like to submit a PR, I'd be happy to review it. Also, there's a few docs in this repository that you may find useful when it comes to making changes, such as the guide on component conventions. Thanks, Jon. |
floehopper
added a commit
that referenced
this issue
Sep 25, 2023
As suggested in #3510. This changes the date-input component so it supports errors on individual input elements, e.g. just the year input element. This usage is described in the docs for the date-input component [1]: > If you’re highlighting just one field - either the day, month or year > - only style the field that has an error. The error message must say > which field has an error, like this: However, highlighting just one field like this is not actually currently supported by the date-input component! The new behaviour (where individual fields are highlighted as having an error) is specified by adding values for a `name` key to the `error_items` with the values matching the values of the `name` key in the `items`. If none of the `error_items` have a value for the `name` key, then we fallback to the original behaviour, i.e. all fields are highlighted as having an error. This should hopefully make this a fairly backwardly-compatible change. [1]: https://design-system.service.gov.uk/components/date-input/#error-messages
floehopper
added a commit
that referenced
this issue
Sep 25, 2023
As suggested in #3510. This changes the date-input component so it supports errors on individual input elements, e.g. just the `year` input element. This usage is described in the docs for the date-input component [1]: > If you’re highlighting just one field - either the day, month or year > - only style the field that has an error. The error message must say > which field has an error, like this: However, highlighting just one field like this is not actually currently supported by the date-input component which is a bit confusing! The new behaviour (where individual fields are highlighted as having an error) is specified by adding values for a `name` key to the `error_items` with the values matching the values of the `name` key in the `items`. If none of the `error_items` have a value for the `name` key, then we fallback to the original behaviour, i.e. all fields are highlighted as having an error. This should hopefully make this a fairly backwardly-compatible change. [1]: https://design-system.service.gov.uk/components/date-input/#error-messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation for error messages on a Date Input says:
However, the
date_inputcomponent doesn't currently support this use case - you can have multiple error items, but they all have to refer to the component as a whole.I'd be willing to open a PR for this if it's likely to be accepted...
The text was updated successfully, but these errors were encountered: