From 88b3ee5f3f3b2c6277dd0030bf7a98f4d3a85294 Mon Sep 17 00:00:00 2001
From: syed-ali-tw <syed.ali1@digital.cabinet-office.gov.uk>
Date: Thu, 26 Sep 2024 14:01:30 +0100
Subject: [PATCH] Fix homepage controller params to deal with BSON upgrade
 nuances

---
 app/controllers/homepage_controller.rb | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/app/controllers/homepage_controller.rb b/app/controllers/homepage_controller.rb
index 91d424e2d..e77613c58 100644
--- a/app/controllers/homepage_controller.rb
+++ b/app/controllers/homepage_controller.rb
@@ -19,7 +19,7 @@ def edit
   end
 
   def update
-    @latest_popular_links.link_items = remove_leading_and_trailing_url_spaces(params[:popular_links].values)
+    @latest_popular_links.link_items = remove_leading_and_trailing_url_spaces(permitted_params.values)
     @latest_popular_links.save_draft
 
     flash[:success] = "Popular links draft saved.".html_safe
@@ -72,6 +72,10 @@ def confirm_destroy
 
 private
 
+  def permitted_params
+    params.permit(popular_links: %i[title url])
+  end
+
   def cannot_delete_published_error_message
     "Can't delete an already published edition. Please create a new edition to make changes.".html_safe
   end
@@ -108,7 +112,7 @@ def remove_leading_and_trailing_url_spaces(links)
     link_items = []
     links.each do |link|
       link[:url] = link[:url].strip
-      link_items << link
+      link_items << link.to_h
     end
     link_items
   end