From 966f046633603f3615886acbae560d633aae872d Mon Sep 17 00:00:00 2001 From: davidtrussler Date: Wed, 4 Sep 2024 18:44:58 +0100 Subject: [PATCH] Fix `filtered_editions_presenter_test` --- app/presenters/filtered_editions_presenter.rb | 6 +++++- test/unit/presenters/filtered_editions_presenter_test.rb | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/app/presenters/filtered_editions_presenter.rb b/app/presenters/filtered_editions_presenter.rb index c50cb79bc..eb62c7080 100644 --- a/app/presenters/filtered_editions_presenter.rb +++ b/app/presenters/filtered_editions_presenter.rb @@ -43,10 +43,14 @@ def edition_states states end + def available_users + User.enabled.alphabetized + end + def assignees users = [{ text: "All assignees", value: "" }] - User.enabled.alphabetized.map do |user| + available_users.map do |user| users << if user.id.to_s == @assigned_to_filter { text: user.name, value: user.id, selected: "true" } else diff --git a/test/unit/presenters/filtered_editions_presenter_test.rb b/test/unit/presenters/filtered_editions_presenter_test.rb index f68d658fc..45d5318bc 100644 --- a/test/unit/presenters/filtered_editions_presenter_test.rb +++ b/test/unit/presenters/filtered_editions_presenter_test.rb @@ -60,7 +60,7 @@ class FilteredEditionsPresenterTest < ActiveSupport::TestCase guide = FactoryBot.create(:guide_edition) FactoryBot.create(:completed_transaction_edition) - filtered_editions = FilteredEditionsPresenter.new(format_filter: "guide").editions + filtered_editions = FilteredEditionsPresenter.new(content_type_filter: "guide").editions assert_equal([guide], filtered_editions.to_a) end @@ -69,7 +69,7 @@ class FilteredEditionsPresenterTest < ActiveSupport::TestCase FactoryBot.create(:guide_edition) FactoryBot.create(:completed_transaction_edition) - filtered_editions = FilteredEditionsPresenter.new(format_filter: "all").editions + filtered_editions = FilteredEditionsPresenter.new(content_type_filter: "all").editions assert_equal(2, filtered_editions.count) end