-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit page for published editions #2559
Open
mtaylorgds
wants to merge
11
commits into
main
Choose a base branch
from
601-edit-page-for-published-edition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a partial for the fields that are common to all content types.
7bda6bf
to
a9bf44a
Compare
Refactor the partial so that the form wraps the content and sidebar for draft editions, but not for published editions. The sidebar for published editions will need to have its own form to enable the "Create new edition" button to post to a separate endpoint (and the main content of published editions has no interactivity and therefore no need for a form).
Add a button for creating a new edition of an artefact, when viewing a published edition and there is no draft edition of the same artefact.
Add a link to the draft of an artefact, when viewing a published edition where a draft edition already exists.
Add a link to view the published page on GOV.UK when viewing a published edition.
The helper can be written to make it more obvious that the "Create new edition" and "Edit latest edition" options are mutually exclusive.
For editions not in the "published" state.
a9bf44a
to
a6ff2b3
Compare
Only show the buttons if the user has the right permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Display a published edition's content as read-only on the "edit" tab when viewing an edition.
Also implements a sidebar, allowing users to view a later draft edition (if one exists), or create a new draft edition (if one doesn't already exist), and also view the published page on GOV.UK.