From 7ea512e7c9943fd0e75c19fabc98b6f0c116547e Mon Sep 17 00:00:00 2001 From: Leena Gupte Date: Mon, 8 Jan 2024 17:04:06 +0000 Subject: [PATCH] Remove the search-analytics smokey tests The three search queries used in these smokey tests are inflating and polluting the clickboost search data. The GA4/Analytics team tried to filter out the Smokey data at the GA4 end but weren't fully able to. The test can be removed for a few reasons: 1. The clickboost data is being used to evaluate the new search product and that can't happen effectively if the clickboost data thinks pages are popular based on clicks occurring in tests. Once the new product is live it will continue to effect the results that users see. 2. search-analytics hasn't worked properly since the move to kubernetes, though work is being done to retify this. 3. These tests check for Univeral Analytics which is being removed, so the tests will need to br written anyhow. --- features/apps/finder_frontend.feature | 6 ------ features/step_definitions/analytics.rb | 15 --------------- 2 files changed, 21 deletions(-) diff --git a/features/apps/finder_frontend.feature b/features/apps/finder_frontend.feature index 8458180c..9fdbcd45 100644 --- a/features/apps/finder_frontend.feature +++ b/features/apps/finder_frontend.feature @@ -19,12 +19,6 @@ Feature: Finder Frontend When I search for "" Then I should see some search results And the search results should be unique - And search analytics for "" are reported - When I go to the next page - Then the "contentsClicked" event is reported - When I click result 1 - Then the "navFinderLinkClicked" event for result Search.1 is reported - And the "UX" event for result click is reported Examples: | keywords | diff --git a/features/step_definitions/analytics.rb b/features/step_definitions/analytics.rb index c1ff6d68..372b6867 100644 --- a/features/step_definitions/analytics.rb +++ b/features/step_definitions/analytics.rb @@ -1,18 +1,3 @@ -Then /^search analytics for "(.*)" are reported$/ do |term| - sought = CGI::escape("/search/all?keywords=#{term.sub(' ', '+')}") - expect(browser_has_analytics_request_containing sought).to be(true) -end - -Then /^the "(.*)" event is reported$/ do |event| - sought = "ec=#{event}" - expect(browser_has_analytics_request_containing sought).to be(true) -end - -Then /^the "(.*)" event for result (.*) is reported$/ do |event, n| - sought = "ec=#{event}&ea=#{n}" - expect(browser_has_analytics_request_containing sought).to be(true) -end - Then /^the page view should be tracked$/ do sought = "t=pageview" expect(browser_has_analytics_request_containing sought).to be(true)