Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded and/or deprecated styles #2239

Open
danacotoran opened this issue Jul 20, 2020 · 1 comment
Open

Remove unneeded and/or deprecated styles #2239

danacotoran opened this issue Jul 20, 2020 · 1 comment

Comments

@danacotoran
Copy link
Contributor

  1. There are numerous instances where we are defining base styles for elements, the downsides of which are highlighted in more detail in the following comments:
    Remove dependency on govuk_frontend_toolkit typography #2238 (comment)
    Remove dependency on govuk_frontend_toolkit typography #2238 (comment)
    We should no longer be defining styles this way in a componentised GOVUK. In order to remove these styles safely it is necessary to search applications, removing any dependencies of the thing we're aiming to remove from static. Alternatively, if the deprecated styling is only used in one application, we can move them out of static and into that application.

  2. There might be many classes in static which are no longer in use, and can therefore be removed
    Remove dependency on govuk_frontend_toolkit typography #2238 (comment)
    Similar to above, in order to achieve this we should search the applications and either move the classes into the applications that need them, or, if the classes aren't used anywhere, remove them from static entirely

@andysellick
Copy link
Contributor

@danacotoran is this still an issue? Is there any more work to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants