Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-rendered attachment markup can be removed from content items #9142

Open
andysellick opened this issue Jun 12, 2024 · 0 comments
Open

Pre-rendered attachment markup can be removed from content items #9142

andysellick opened this issue Jun 12, 2024 · 0 comments

Comments

@andysellick
Copy link
Contributor

The content item for page types publications, consultations and calls for evidence contains a pre-rendered chunk of markup generated in whitehall that was used to display attachments on these pages.

We've recently done some work to move away from using this pre-rendered markup (in details->documents), instead using the other data in the content item (details->attachments) to generate the same output using components within the application (government-frontend).

I believe that it is therefore safe to now remove this pre-rendered markup from the content item.

Pull requests where we made these changes:

The card for the work to switch away from the pre-rendered markup is here: https://trello.com/c/tcTN1jbu/28-update-rendering-of-govspeak-attachments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant