Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outline-promote/demote space issue and add extra-face support #90

Closed
wants to merge 1 commit into from

Conversation

jdtsmith
Copy link

@jdtsmith jdtsmith commented Dec 29, 2021

This PR fixes #63, which results from an unnecessary space being added directly into outline-regexp. This space is needed for proper font-locking, so it is included there.

Also included is a new customize variable outshine-outline-extra-face, which, if set, can be used to configure the face of the outline match itself (e.g. ;;;;, # ***, etc.).

For example, by adding :overline and :extend to the outshine faces, you can then achieve some good-looking separators (see below). Along the way, outshine-headings-list is generalized.

@jdtsmith
Copy link
Author

Here's an example of the new face configurability in use:

image

@alphapapa
Copy link
Owner

Apparently I overlooked this PR for a while, until it appeared in my issues list again just now. Please feel free to ping me in the future if I overlook it again (I don't work on this project very often).

I'll make some comments as a review. Thanks for your work on this.

Copy link
Owner

@alphapapa alphapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

README.org Show resolved Hide resolved
outshine.el Outdated Show resolved Hide resolved
outshine.el Outdated Show resolved Hide resolved
@jdtsmith
Copy link
Author

jdtsmith commented May 2, 2022

Apparently I overlooked this PR for a while, until it appeared in my issues list again just now. Please feel free to ping me in the future if I overlook it again (I don't work on this project very often).

Thanks no worries. I've been using this branch for several months without problem.

@alphapapa
Copy link
Owner

Thanks. As a final step, if you would update the changelog in the readme and squash the branch, it could be merged directly then.

@jdtsmith jdtsmith force-pushed the extra-face-fix-space branch from 74fa481 to d3a1608 Compare May 5, 2022 19:14
@jdtsmith
Copy link
Author

jdtsmith commented May 5, 2022

Thanks. As a final step, if you would update the changelog in the readme and squash the branch, it could be merged directly then.

Done thanks.

@jdtsmith
Copy link
Author

jdtsmith commented Jun 5, 2022

@alphapapa: a ping, as requested.

@jdtsmith
Copy link
Author

Closing this in favor of my new much simpler mode outli which includes this type of styling by default.

@jdtsmith jdtsmith closed this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outline-{promote, demote} does not seem to work well.
2 participants