-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix outline-promote/demote space issue and add extra-face support #90
Conversation
Apparently I overlooked this PR for a while, until it appeared in my issues list again just now. Please feel free to ping me in the future if I overlook it again (I don't work on this project very often). I'll make some comments as a review. Thanks for your work on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Thanks no worries. I've been using this branch for several months without problem. |
Thanks. As a final step, if you would update the changelog in the readme and squash the branch, it could be merged directly then. |
74fa481
to
d3a1608
Compare
Done thanks. |
@alphapapa: a ping, as requested. |
Closing this in favor of my new much simpler mode outli which includes this type of styling by default. |
This PR fixes #63, which results from an unnecessary space being added directly into
outline-regexp
. This space is needed for proper font-locking, so it is included there.Also included is a new customize variable
outshine-outline-extra-face
, which, if set, can be used to configure the face of the outline match itself (e.g.;;;;
,# ***
, etc.).For example, by adding
:overline
and:extend
to the outshine faces, you can then achieve some good-looking separators (see below). Along the way,outshine-headings-list
is generalized.