Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom file extensions #13

Open
ryanmerolle opened this issue Jan 26, 2023 · 2 comments
Open

Allow for custom file extensions #13

ryanmerolle opened this issue Jan 26, 2023 · 2 comments

Comments

@ryanmerolle
Copy link

Given the shift to multi-vendor support, in the plugin config, you should be able to provide a list of file extensions.

We could likely create another issue to set a filte extension check for each platform.

For now, we should focus on allowing the list to be edited.

As an example:
Arista: ".swi"
Cisco: ".bin"
Fortinet: ".out"
Palo Alto: no extension (might be challenging, but most use the UI)
Cumulus: ".bin"
Sonic: looks like no file extension
Juniper: I cannot remember
Opengear: ".flash"

Typing this out, we may want to allow any filename/extension. Thoughts?

@alsigna
Copy link
Owner

alsigna commented Jan 26, 2023

I left only .bin filter as plugin can upload/upgrade only Cisco IOS boxes. Someone can try to upload/upgrade device with wrong type of image in case of filter will be less strict. Also I do not have infrastructure to test upload/upgrade for other kind of vendors.

Probably, SoftwareImage model can have reference to Manufacturer model... will think about it. But (imho) just extending image filter can be dangerous.

@ryanmerolle
Copy link
Author

Yep I agree. I think the gaurs tail you put in place for upgrades by not allowing non bin files to be uploaded should just move to the upgrade process that would check platform is logic. I'm happy to help and think about this also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants