Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark_errorbar silently fails #43

Open
ValdarT opened this issue Dec 19, 2019 · 2 comments
Open

mark_errorbar silently fails #43

ValdarT opened this issue Dec 19, 2019 · 2 comments

Comments

@ValdarT
Copy link

ValdarT commented Dec 19, 2019

import pandas as pd
import altair as alt
from altair_transform import transform_chart

df = pd.read_json('https://vega.github.io/vega-datasets/data/iris.json')

error_bars = alt.Chart(df).mark_errorbar(extent='ci').encode(
  x=alt.X('petalLength:Q', scale=alt.Scale(zero=False)),
  y=alt.Y('species:N')
)

transform_chart(error_bars)

The transformation does not take place but NotImplementedError is also not raised (which would be expected based on the Limitations section in the README).

@ValdarT
Copy link
Author

ValdarT commented Dec 19, 2019

A general comment: I'd really like this and concatenated charts to be supported so that it would be easy to create charts like this on larger datasets with Altair: https://altair-viz.github.io/gallery/errorbars_with_ci.html

@jakevdp
Copy link
Member

jakevdp commented Dec 19, 2019

Thanks – your chart contains no direct data transforms, so the code lets it pass through unmodified. There are transforms implied by mark_errorbar, but altair-transform does not yet recognize those.

Concatenated charts have not yet been implemented, because nobody has yet chosen to contribute that.

If you would like to contribute either of these features, please feel welcome, and let me know if you have questions about how to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants