-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip 1.1.3 and support jupyterlab 1.1.4👍 #78
Comments
sorry guys, been swamped with some other things so ihaven't had to chance to dig into updating the repo. The weird thing is that I've been using a jupyter docker stack which has 1.1.3 and haven't had any problems with the voyager extension being built...i've been rebuilding everyday as well I still plan to look into this and see how we can get it up to par with 1.1.4 though, anyone's free to hop in and do a PR if i don't get to it before though |
Just tried to install in 1,1,4 and got these errors:
|
I have the same error. We are running jupyter lab 1.1.4 in a shared jupyterhub environment. lab 1.2.0 just came out, but from what I'm seeing above I don't think that will help. |
Hey @saulshanabrook would you mind taking a look here? I went ahead and downgraded the react and react-dom to 16.8.6 (Not sure why now it doesn't like the 17.x. version) but now there's some weird errors happening. The build succeeds but when jupyterlab actually trys to load the extension there's a runtime error happening
Dug into it a little and looks like it's stemming from the datavoyager library and react proptypes api being changed to come from core react lib instead of it's own proptypes library. If this is the case i'm not sure what we can do to get this package working without going upstream to the datavoyager library? It just seems odd that now it would start acting up...even when reverting to a previous working react and react-dom package |
also realized even though i had a docker image for 1.1.3, i was downgrading jupyelab to 1.0.4, so this statement is wrong |
I got the same problem with jupyterlab 1.1.4 |
Its been so long and i guess no solution came till now. I tried installing lab v2.0.1 , v1.1.4, v1.13, v1.1.0. None builds properly. All have the same error.
Is there any workaround or anything can be done to resolve?? |
@falzberger Forcing react 16 is not the right approach I believe, since upstream datavoyager uses 15. |
When I attempt to install I get an Error:
An error occurred.
ValueError: No version of jupyterlab_voyager could be found that is compatible with the current version of JupyterLab. However, it seems to support a new version of JupyterLab. Consider upgrading JupyterLab.
The text was updated successfully, but these errors were encountered: