Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make solarized great again! #371

Open
purpleP opened this issue Jul 24, 2017 · 12 comments
Open

Make solarized great again! #371

purpleP opened this issue Jul 24, 2017 · 12 comments

Comments

@purpleP
Copy link

purpleP commented Jul 24, 2017

It seems that @altercation have abandoned this project.

How about we create an organization in github where the community could continue development (mostly bugfixes)?

Couple of goals I have in mind.

Make solarized work with termguicolors (maybe even throw away all terminal specific code if enough users use vim8).

Fix SignColumn highlighting
turn this exe "hi! SignColumn" .s:fmt_none .s:fg_base0 back into this
exe "hi! SignColumn" .s:fmt_none .s:fg_base0 .s:bg_base02
Y U do dis @juhasz?
or just link it to LineNr which have the same exact effect.

Fix strange red/yellow CurrentLineNr in light/dark mode (yellow was visible only in gui). I'm pretty sure this wasn't intended. Seems like this highlighting group have been forgotten and vim used default values.

All this is fixed in my fork right now.

@sleicht
Copy link

sleicht commented Aug 29, 2017

That sounds reasonable.
Can you give a link to your fork?

Has @altercation any objection to this?

@purpleP
Copy link
Author

purpleP commented Aug 29, 2017

@sleicht https://github.com/purpleP/vim-colors-solarized.git

@juanibiapina
Copy link

This repo does need some love. I guess we can contact @altercation somewhere to check what his thoughts are.

@purpleP
Copy link
Author

purpleP commented Oct 27, 2017

@juanibiapina I tried that on twitter and here. No response, although he's alive.

@Potherca
Copy link

Related issues: #355

@Potherca
Copy link

I think the most sane road forward would be te see who can get in touch with @altercation, set up a plan of attack and appoint more maintainers to be part of the Solarized organization already on Github.

@mlippert
Copy link

@kbobyrev, @purpleP @Potherca There are a boatload of forks of this project. You 3 seemed most proactive about created a new "active" fork of this plugin (based solely on the this issue and the one that brought me here).

Has any particular fork been anointed as the "new master copy" as suggested above and in #375?

I hadn't had any issues with it until now (vim/vim#3014) which is exposed by solarized not making sure the cpoptions are set as required ( think that save-set-restore of cpoptions should happen in colors/solarized.vim to be safe).
At the beginning (these lines were just copied from menu.vim but I've seen them in many other files):

" Make sure the '<' and 'C' flags are not included in 'cpoptions', otherwise
" <CR> would not be recognized.  See ":help 'cpoptions'".
let s:cpo_save = &cpo
set cpo&vim

and

" Restore the previous value of 'cpoptions'.
let &cpo = s:cpo_save
unlet s:cpo_save

at the end.

@purpleP
Copy link
Author

purpleP commented Jun 27, 2018

@mlippert It hadn't because no one was voting. So I guess I would have to just do it and then anyone who wants can join.

@mlippert
Copy link

mlippert commented Jul 7, 2018

I use and like the vim solarized plugin, but probably in the most minimal fashion. I haven't actually run into any issues (until what I mentioned above). I would certainly use an updated version, but creating it seems like a lot of work that I wouldn't ask anyone to do, since I'm personally not likely to contribute much. If a fork w/ fixes is created, definitely mention it here though, because I'd like to switch over and use it.

@brainbug89
Copy link

Any updates? In #355 @altercation and @TrevorBramble mentioned that they're working on a solution to this situation. But not infos since then. 😞

@purpleP
Copy link
Author

purpleP commented May 15, 2019

@brainbug89 You can look at my fork if you want to start community fork.

I've reworked the code significantly making it easier to understand and removing irrelevant features (like supporting old terminals)

@logan-life
Copy link

Any update on the quest to revitalize Solarize in a fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants