-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go2port update please v17.6.2 results in invalid go.vendor entries #9
Comments
go2port uses its own very simple package-resolving logic (I don't know where the "real" logic is or whether it's reusable in an application like go2port). This logic can't handle submodule dependencies correctly. For instance This means that if the project wants versions of Sometimes you'll get lucky and everything will work fine. Some ports are built like this and seem to work fine, or maybe they're subtly buggy but no one has noticed. So if you like to gamble like this, the trick to getting the portfile to work is:
Thus you can see that go2port is really a hack that only works well when a project happens to have well-behaved dependencies. I'm sure it could be improved by someone who has better knowledge of golang dependency resolution, but that's not me. The MacPorts project as a policy strongly discourages downloading dependencies at build time, but there are some golang ports that do so because getting the golang-1.0 portgroup and go2port to work for them is so cumbersome. If you do want to go with go2port, I have manually applied the above fixes: Manually fixed go.vendors
|
Also I should note that I already released an update to go2port that has some changes that make things a little bit easier to diagnose:
|
Thank you for your response and the updated release. I’ll look at it more in depth this evening, but your explanation makes sense. |
So, I finally had a chance to try this. The resulting portfile still doesn't work — but that's because I think there's something fundamentally broken about the golang portgroup. The tags for the AWS tree files are specific to the sub-SDK being looked at — for STS, it should be trying to download I spent a bit of time reading trac:61192 and then looking at what The next best choice would be to have maintainers run |
I ran
go2port update please v17.6.2 --output Portfile
and things looked good, butsudo port install
fails because of 404s on archives.This doesn't entirely make sense for the initial failure (
aws-aws-sdk-go-v2-service-v1.17.6.tar.gz
), which is added togo.vendors
as:However, there are 26 entries in
go.vendors
which result insize 14
and identicalrmd160
/sha256
blocks, because it's all404 Not Found
.I'm not sure if these issues are related, but something feels off, regardless, and I’m not sure where to begin.
I'm attaching the updated/generated
Portfile
for reference.The text was updated successfully, but these errors were encountered: