Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise commits convention #8

Open
Dako99 opened this issue May 6, 2022 · 2 comments
Open

Standardise commits convention #8

Dako99 opened this issue May 6, 2022 · 2 comments

Comments

@Dako99
Copy link
Contributor

Dako99 commented May 6, 2022

It isn't nesesery for us but will be great to practice on project like this.

  • Add type of commit (fix, refactor, documentation / doc)
  • Use the imperative mood in the subject line
  • Dont use polish (🇵🇱 stronk)
  • much more, idk borrow sth form Opera (@jestem-andrew ), check web, Im sure you know or will know more than me (I'm n00b)

This is great for small and clear fixes also if we want be BigChads we can use multi-line commits.

@amalolepszy
Copy link
Owner

Easy way of adding fixups is using the git commit --fixup=HEAD command.
As writing code is being done not on the rpi, but on other machines, and then pulled to the rpi, there will be lots of new minuscule commits.
Imo it's a good idea to keep commits short and concise, and to give more specific information on pull requests.
Also, no Polish is also a good idea.

@amalolepszy
Copy link
Owner

In order to keep code nice and standarized, we could use pylint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants