Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has the laterst changes of Web3, as of 2021, been incorporated? #189

Open
naddika opened this issue Mar 22, 2021 · 11 comments
Open

Has the laterst changes of Web3, as of 2021, been incorporated? #189

naddika opened this issue Mar 22, 2021 · 11 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@naddika
Copy link

naddika commented Mar 22, 2021

Has the laterst changes of Web3.js, as of 2021, been incorporated? Does this demo work properly with the laterst versions of MetaMask?

@amaury1093
Copy link
Owner

I'm not 100% sure. Would you like to try and report back?

@amaury1093 amaury1093 added the question Further information is requested label Mar 22, 2021
@tombenj
Copy link

tombenj commented Mar 23, 2021

@AmauryM I'm getting this:

Failed to compile
src/Login/Login.tsx
Syntax error: Unexpected token, expected ";" (40:32)

  38 | 	}) => {
  39 | 		try {
> 40 | 			const signature = await web3!.eth.personal.sign(
     | 			                            ^
  41 | 				`I am signing my one-time nonce: ${nonce}`,
  42 | 				publicAddress,
  43 | 				'' // MetaMask will ignore the password argument here

@gotnull
Copy link

gotnull commented Jul 8, 2021

Any update on this?

@amaury1093
Copy link
Owner

Hey everyone, thanks for your interest in this project! I unfortunately will not have time to work on this issue in the near future, so I'm leaving it for the community. If anyone wants to explore what's going on here, please do!

@amaury1093 amaury1093 added help wanted Extra attention is needed good first issue Good for newcomers and removed question Further information is requested labels Jul 8, 2021
@amaury1093 amaury1093 pinned this issue Jul 8, 2021
@lucaswjohnson
Copy link

@tombenj @gotnull @naddika I just connected to my metamask just fine without changing anything. Can you explain what you're doing to produce the error so I can reproduce it please?

@steoniy
Copy link

steoniy commented Aug 5, 2021

@tombenj @gotnull @naddika I just connected to my metamask just fine without changing anything. Can you explain what you're doing to produce the error so I can reproduce it please?

I am experiencing same issue, just by running docker-compose up -d and trying to access localhost:3000

@amaury1093
Copy link
Owner

Please note that this might also be related to #174: I could run with yarn start, but the dockerfile didn't work.

@q9f
Copy link

q9f commented Sep 6, 2021

The original issue is pretty vague, but I also stumbled across this today; mainly because MetaMask stopped injecting web3: https://docs.metamask.io/guide/provider-migration.html#replacing-window-web3

I raised a discussion on Stack Exchange because I cannot find any working reference of eth_personalSign in the latest version of MetaMask though: https://ethereum.stackexchange.com/questions/109472/how-to-authenticate-with-an-ethereum-account-through-personalsign - FYI.

I'm basically working on bringing Ethereum SSO to Rails but the MetaMask reference is still a bit spotty in that regard.

@sledmonkey
Copy link

@q9f looks like you had a reply to your stack exchange. Does that help here?

@sledmonkey
Copy link

@tombenj @gotnull @naddika I just connected to my metamask just fine without changing anything. Can you explain what you're doing to produce the error so I can reproduce it please?

Not working for me either and getting same error as op. Have tried using docker-compose and docker run approaches (Readme 1 & 2).

Readme option 3 gives me a completely different error.
src/App/App.tsx Line 36:8: Avoid referencing unbound methods which may cause unintentional scoping of this @typescript-eslint/unbound-method

@q9f
Copy link

q9f commented Sep 29, 2021

@q9f looks like you had a reply to your stack exchange. Does that help here?

Yes, I have completed an MVP using Rails and the new MetaMask API, you can check the README here: https://github.com/q9f/ethereum-on-rails#how-it-works and scroll down to "How it works"

I also "translated" the APIs in this ticket, that has the latest window.ethereum calls that work exactly like described in the tutorial by @AmauryM: q9f/omniauth-ethereum.rb#1 (Scroll down to "Frontend MVP"!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants