Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped vs non-wrapped variants of AbstractDataType for codegen model #145

Open
desaikd opened this issue Sep 25, 2024 · 0 comments
Open
Labels
code generation Improvements for code generation subcommand `generate`

Comments

@desaikd
Copy link
Contributor

desaikd commented Sep 25, 2024

Currently AbstractDataType has 2 variants for sequence/scalar types(i.e. wrapped vs non-wrapped). The non-wrapped variant here is always generated as nested part of some other class and might not require to be represented as a model because the details for it can be stored in the class itself.
Currently, its FullyQualifiedTypeReference name is getting stored in the TypeStore and the fields property of a structure(class) has a reference to it. Look into removing these non-wrapped variants and see if it has any requirements to keep it for templates.

More discussion: #144 (comment)

@desaikd desaikd added the code generation Improvements for code generation subcommand `generate` label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code generation Improvements for code generation subcommand `generate`
Projects
Status: No status
Development

No branches or pull requests

1 participant