Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a trait that can eb implemented by each languages supported by code gen #71

Closed
desaikd opened this issue Dec 7, 2023 · 2 comments
Closed

Add a trait that can eb implemented by each languages supported by code gen #71

desaikd opened this issue Dec 7, 2023 · 2 comments
Labels
code generation Improvements for code generation subcommand `generate`

Comments

@desaikd
Copy link
Contributor

desaikd commented Dec 7, 2023

Currently we're mixing the configuration for the different languages here. This is going to become a maintainability problem if/when more languages are added. A better approach would be to create a trait with functions for mappings like this. Then the trait can be implemented for a RustLanguage unit struct and a JavaLanguage unit struct.

Originally posted by @popematt in #61 (comment)
@desaikd desaikd added the code generation Improvements for code generation subcommand `generate` label Dec 7, 2023
@desaikd desaikd mentioned this issue Dec 7, 2023
Merged
@desaikd
Copy link
Contributor Author

desaikd commented Dec 12, 2023

As discussed here: #61 (comment)
Sequence can store the data type of the collection so that it doesn't need to be extracted from the data type name.

@desaikd desaikd mentioned this issue Feb 7, 2024
Merged
@desaikd
Copy link
Contributor Author

desaikd commented Apr 9, 2024

Completed with #81

@desaikd desaikd closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code generation Improvements for code generation subcommand `generate`
Projects
Code generation using Ion Schema
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@desaikd