Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support POCO serialisation #121

Open
fmannhardt opened this issue Jun 13, 2020 · 7 comments
Open

Does not support POCO serialisation #121

fmannhardt opened this issue Jun 13, 2020 · 7 comments

Comments

@fmannhardt
Copy link

The readme indicates that I could serialise any POCO object using:

//Serialize an object to byte array
byte[] ionBytes = IonSerialization.Binary.Serialize(experiment);

However, I cannot find the class IonSerialization.

@dhhoang
Copy link
Contributor

dhhoang commented Jun 15, 2020

It seems like the serialization features have been excluded from the 1.0 release: https://github.com/amzn/ion-dotnet/releases/tag/v1.0.0
Someone should update the README file.

Is there any plan to support this feature in the upcoming release? This is useful for a lot of .NET users.

@tgregg
Copy link
Contributor

tgregg commented Jun 22, 2020

Yes, we removed this API for the 1.0 release to reduce the API surface area. If there is enough demand for it, it could be added in a future release.

For now, I will update the readme to avoid the confusion.

@adrianiftode
Copy link

I would like to dump a bunch of objects into a Ledger database and I'm thinking a POCO serializer would help. Is there a timeline for adding this feature back?

@dhhoang
Copy link
Contributor

dhhoang commented Jul 11, 2020

I am also having an use case where this is feature is needed.
@tgregg what are the steps required to implement & test this one?

@tgregg
Copy link
Contributor

tgregg commented Jul 27, 2020

@dhhoang We need to resurrect the code from this branch: https://github.com/amzn/ion-dotnet/tree/bench-and-serialization-projects

It can be submitted as a PR with its associated tests. Once we've reviewed and merged it, we can create a new release that includes it.

@ChiefInnovator
Copy link

I really like this project but without the POCO serialization, it is almost useless for general adoption.

@tgregg
Copy link
Contributor

tgregg commented Aug 9, 2022

@ChiefInnovator The following library may help! https://github.com/amzn/ion-object-mapper-dotnet/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants