Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider caching findCaseInsensitiveFieldMatch #66

Open
jobarr-amzn opened this issue Dec 1, 2021 · 0 comments
Open

Consider caching findCaseInsensitiveFieldMatch #66

jobarr-amzn opened this issue Dec 1, 2021 · 0 comments

Comments

@jobarr-amzn
Copy link
Contributor

When case insensitivity is enabled the serde may iterate through each struct looking for case-insensitive field matches. A cache in findCaseInsensitiveFieldMatch could speed up this process, reducing struct scans.

https://github.com/amzn/ion-hive-serde/blob/c37e29944b0f25fe08551a6c716a61a3c64181d0/serde/src/main/java/com/amazon/ionhiveserde/caseinsensitivedecorator/IonStructCaseInsensitiveDecorator.java#L125-L132

Would it be worth it? Worth looking at at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant