Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark CLI compare can have inaccurate results for some metrics #281

Open
popematt opened this issue Aug 1, 2023 · 0 comments
Open

Benchmark CLI compare can have inaccurate results for some metrics #281

popematt opened this issue Aug 1, 2023 · 0 comments
Labels
bug

Comments

@popematt
Copy link
Contributor

popematt commented Aug 1, 2023

The compare command in the benchmark CLI always assumes lower is better. This is not true when measuring e.g. ops per second, and so the compare command can erroneously detect regressions for those metrics.
@popematt popematt added the bug label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@popematt