Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Python Error Handling from ioncmodule #310

Open
rmarrowstone opened this issue Nov 29, 2023 · 0 comments
Open

Improve Python Error Handling from ioncmodule #310

rmarrowstone opened this issue Nov 29, 2023 · 0 comments

Comments

@rmarrowstone
Copy link
Contributor

Many of the calls to the Python C API in ioncmodule are not checked for NULL return values, which would indicate an error, for example in ionc_add_to_container. For the most part one would only encounter these errors when actively developing or if the hardware was truly out of memory (in which the process is pretty much cooked anyway). But having better error info would help during development and debugging.

Given that the ioncmodule code is intended to be called from the python interpreter it would be better to capture the Python error information to ensure that propagated into the Python exceptions that are thrown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant