Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ion_type() correctly reflect typed nulls #828

Open
zslayton opened this issue Sep 3, 2024 · 0 comments
Open

Make ion_type() correctly reflect typed nulls #828

zslayton opened this issue Sep 3, 2024 · 0 comments

Comments

@zslayton
Copy link
Contributor

zslayton commented Sep 3, 2024

          Could you put this functionality in a `self.read_null()` method instead of having it happen in `ion_type()`?

There are three other raw value types besides LazyRawBinaryValue_1_1:

  • LazyRawBinaryValue_1_0
  • LazyRawTextValue_1_1
  • LazyRawTextValue_1_0

Each of them has an ion_type() method and I'm pretty sure at least some of them return IonType::Null if the value is a null value, even if it's a typed null. The behavior you've implemented is probably more correct, but if we make this change here we'd need to make it in the other three places too.

Originally posted by @zslayton in #826 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant