Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ISL model to retain order of non-ISL(open content) and ISL values #147

Open
desaikd opened this issue Feb 14, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@desaikd
Copy link
Contributor

desaikd commented Feb 14, 2023

Current implementation model of ISL doesn't store the relative order for ISL and non ISL contents.
The following can not be differentiated with current implementation:

$foo
$bar
type::{ name: foo, codepoint_length: 1 }

and

type::{ name: foo, codepoint_length: 1 }
$foo
$bar

In order to preserve this relative order IslSchema should be changed to contain a vector of enums where the enum can have either ISL or non ISL(open content). A possible enum could look like following:

enum IslContent {
     TyepDef(TyepDef),
     OpenContent(Element),
}

Reference comment: #145 (comment)

@desaikd desaikd added the enhancement New feature or request label Feb 14, 2023
@popematt popematt changed the title Chaneg ISL mdoel to store non ISL(open content) and ISL relative order Change ISL model to retain order of non-ISL(open content) and ISL values Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant