Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esmi_ib_library does not compile, error: ‘HSMP_GET_RAPL_UNITS’ undeclared #16

Open
bbagwell-amd opened this issue Oct 4, 2024 · 6 comments

Comments

@bbagwell-amd
Copy link

Hello,

I am having issues compiling esm_ib_library on RHEL 9.4 using the 'master' branch. Diagnostic output included.

The machine I'm compiling on has multiple versions of rocm installed (including 6.1.x, 6.2.x). amdgpu 6.8.5, kernel = 5.14.0-427.13.1.el9_4.x86_64.

Installing esm_ib_library is a requirement for the prometheus amd-smi exporter (which is the only thing I plan on using it for).

It's hard to tell if this is a missing dependency, or perhaps something I'm missing in the installation procedure. Any input you could provide would be most welcome.

make_output.txt

@bbagwell-amd
Copy link
Author

Oh, I should mention as well - I reviewed '#9' , and amd_hsmp.h is "up to date".

@sumachidanand
Copy link
Contributor

Hi,

Please clone https://github.com/amd/amd_hsmp.git and copy amd_hsmp.h to /usr/include/asm/ path in your system and then compile the esmi library. This should fix the error.

@bbagwell-amd
Copy link
Author

bbagwell-amd commented Oct 7, 2024

Thanks Suma!

That was exactly what I was needing!!! Will keep an eye out for cases where headers in nightly builds differ from yum/apt packaged versions.

Unrelated, it looks like https://github.com/amd/goamdsmi/goamdsmi_shim (referenced in the README for the AMD-smi Prometheus exporter README) is no longer available.

Has this repo moved by chance? I need the shim in order to get the exporter working. Happy to make a ticket/issue over there if it helps.

@muralimk-amd
Copy link

Hi,
This entire repository https://github.com/amd/go_amd_smi/ has been moved under Unified SMI repo: "https://github.com/ROCm/amdsmi/". Clone the repo, compile and install.

  • For Inband features, just load amd_hsmp module, No need to clone esm_ib_library because amdsmi repo will clone within it.

To get queries from prometheus amd-smi-exporter Clone https://github.com/amd/amd_smi_exporter/ and follow steps mentioned in readme to configure prometheus and execute.

@bbagwell-amd
Copy link
Author

bbagwell-amd commented Oct 8, 2024

Thanks Muralink!

One - I'll raise a PR to have the amd_smi_exporter folks update their README with this new location.

Two - the cluster that I'm trying to deploy this to can't have nightly builds (and needs to rely on repo.radeon.com packages). Trying to mix nightly builds with the rest of ROCM results in "dependency hell" (small excerpt attached).

Do we know when these go_shim components from the recently moved repo will be integrated into the published builds on repo.radeon.com? I imagine it would be rocm-6.3, but I just want to confirm (since I am not connected to the build/release process for this software).

Sample output:

[root@pm10-nod059 build]# rpm -ivh amd-smi-lib-24.6.3.99999-local.el9.x86_64.rpm
Verifying...                          ################################# [100%]
Preparing...                          ################################# [100%]
        file /opt/rocm/include/amd_smi/amd_smiConfig.h from install of amd-smi-lib-24.6.3.99999-local.el9.x86_64 conflicts with file from package amd-smi-lib6.2.0-24.6.2.60200-66.el9.x86_64
        file /opt/rocm/include/amd_smi/amdsmi.h from install of amd-smi-lib-24.6.3.99999-local.el9.x86_64 conflicts with file from package amd-smi-lib6.2.0-24.6.2.60200-66.el9.x86_64
        file /opt/rocm/libexec/amdsmi_cli/README.md from install of amd-smi-lib-24.6.3.99999-local.el9.x86_64 conflicts with file from package amd-smi-lib6.2.0-24.6.2.60200-66.el9.x86_64
        file /opt/rocm/libexec/amdsmi_cli/_version.py from install of amd-smi-lib-24.6.3.99999-local.el9.x86_64 conflicts with file from package amd-smi-lib6.2.0-24.6.2.60200-66.el9.x86_64
        file /opt/rocm/libexec/amdsmi_cli/amdsmi_cli.py from install of amd-smi-lib-24.6.3.99999-local.el9.x86_64 conflicts with file from package amd-smi-lib6.2.0-24.6.2.60200-66.el9.x86_64
        file /opt/rocm/libexec/amdsmi_cli/amdsmi_commands.py from install of amd-smi-lib-24.6.3.99999-local.el9.x86_64 conflicts with file from package amd-smi-lib6.2.0-24.6.2.60200-66.el9.x86_64
        file /opt/rocm/libexec/amdsmi_cli/amdsmi_helpers.py from install of amd-smi-lib-24.6.3.99999-local.el9.x86_64 conflicts with file from package amd-smi-lib6.2.0-24.6.2.60200-66.el9.x86_64
        file /opt/rocm/libexec/amdsmi_cli/amdsmi_parser.py from install of amd-smi-lib-24.6.3.99999-local.el9.x86_64 conflicts with file from package amd-smi-lib6.2.0-24.6.2.60200-66.el9.x86_64
        file /opt/rocm/share/amd_smi/_version.py from install of amd-smi-lib-24.6.3.99999-local.el9.x86_64 conflicts with file from package amd-smi-lib6.2.0-24.6.2.60200-66.el9.x86_64

@muralimk-amd
Copy link

Sure. will update the amd_smi_exporter README to indicate that go_shim has been moved to amdsmi repo.
I am not sure on published builds on repo.radeon.com, But will check internally when go_shim will be integrated to builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants