Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation issue: GNU M4 with aocc #1

Open
4 tasks done
saikovuri opened this issue Oct 27, 2020 · 1 comment
Open
4 tasks done

Installation issue: GNU M4 with aocc #1

saikovuri opened this issue Oct 27, 2020 · 1 comment
Labels
aocc Problems with aocc bug Something isn't working

Comments

@saikovuri
Copy link

Steps to reproduce the issue

$ spack install m4%aocc
...

Information on your system

  • Spack: 0.14.0-3186-ec0c299
  • Python: 2.7.5
  • Platform: linux-rhel7-zen2

Additional information

spack-build-env.txt
spack-build-out.txt

General information

  • I have run spack debug report and reported the version of Spack/Python/Platform
  • I have run spack maintainers <name-of-the-package> and @mentioned any maintainers
  • I have uploaded the build log and environment files
  • I have searched the issues of this repo and believe this is not a duplicate
@akashyap-amd akashyap-amd added bug Something isn't working aocc Problems with aocc labels Oct 27, 2020
@akashyap-amd
Copy link

Issue in m4 package missing support for aocc.
Addressed in commit b2bf61c

Testing fix

mohan002 pushed a commit that referenced this issue Jun 3, 2021
Before:

```
$ hyperfine '~/spack/bin/spack -e . build-env rocfft'
Benchmark #1: ~/spack/bin/spack -e . build-env rocfft
  Time (mean ± σ):      1.593 s ±  0.016 s    [User: 1.468 s, System: 0.126 s]
  Range (min … max):    1.575 s …  1.628 s    10 runs
```

After:

```
$ hyperfine '~/spack/bin/spack -e . build-env rocfft'
Benchmark #1: ~/spack/bin/spack -e . build-env rocfft
  Time (mean ± σ):      1.407 s ±  0.020 s    [User: 1.280 s, System: 0.127 s]
  Range (min … max):    1.393 s …  1.455 s    10 runs
```
vkallesh pushed a commit that referenced this issue Sep 23, 2021
Git 2.24 introduced a feature flag for repositories with many files, see:
https://github.blog/2019-11-03-highlights-from-git-2-24/#feature-macros

Since Spack's Git repository contains roughly 8,500 files, it can be
worthwhile to enable this, especially on slow file systems such as NFS:
```
$ hyperfine --warmup 3 'cd spack-default; git status' 'cd spack-manyfiles; git status'
Benchmark #1: cd spack-default; git status
  Time (mean ± σ):      3.388 s ±  0.095 s    [User: 256.2 ms, System: 625.8 ms]
  Range (min … max):    3.168 s …  3.535 s    10 runs

Benchmark #2: cd spack-manyfiles; git status
  Time (mean ± σ):     168.7 ms ±  10.9 ms    [User: 98.6 ms, System: 126.1 ms]
  Range (min … max):   144.8 ms … 188.0 ms    19 runs

Summary
  'cd spack-manyfiles; git status' ran
   20.09 ± 1.42 times faster than 'cd spack-default; git status'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aocc Problems with aocc bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants