Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add readlto to ltopers.rb #28

Merged
merged 2 commits into from
Mar 24, 2017
Merged

add readlto to ltopers.rb #28

merged 2 commits into from
Mar 24, 2017

Conversation

NMAAHC
Copy link
Contributor

@NMAAHC NMAAHC commented Mar 20, 2017

is migratelto official? can it be added to the formula?

@retokromer
Copy link
Member

retokromer commented Mar 21, 2017 •
edited
Loading

We were discussing (see amiaopensource/ltopers#2 and amiaopensource/ltopers#66) if migratelto should be renamed readlto, and two new migration scripts added:

  • one combining readlto, save locally, checking and writelto
  • one readlto pipe to checking pipe to writelto without storing locally.

retokromer
retokromer requested changes Mar 21, 2017
View reviewed changes
Copy link
Member

@retokromer retokromer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add, after line 7, revision 1.

@retokromer retokromer changed the title added migratelto to .rb added migratelto to ltopers.rb Mar 21, 2017
@retokromer retokromer changed the title added migratelto to ltopers.rb add readlto to ltopers.rb Mar 24, 2017
@retokromer retokromer merged commit e98119c into amiaopensource:master Mar 24, 2017
@retokromer retokromer mentioned this pull request Mar 24, 2017
Closed
@retokromer
Copy link
Member

@NMAAHC Thank you! Please test and let us know if something is wrong.

@NMAAHC
Copy link
Contributor Author

NMAAHC commented Mar 28, 2017

Thanks! Ok. We will give it a try soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retokromer retokromer retokromer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NMAAHC @retokromer