Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width is off by one #93

Open
fireattack opened this issue Jan 27, 2021 · 1 comment
Open

Width is off by one #93

fireattack opened this issue Jan 27, 2021 · 1 comment
Labels

Comments

@fireattack
Copy link

fireattack commented Jan 27, 2021

I tried two different video files (one 1080p, one 720p), with --width 1000, 1500, 2000. The generated thumbnail file is always off by one (999px, 1499px, 1999px.) All other settings are default.

OS: Windows
FFMPEG version: ffmpeg version git-2020-08-16-5df9724

Version: efd73b3 (newest master)

@amietn amietn added the bug label Jan 27, 2021
@amietn
Copy link
Owner

amietn commented Jan 27, 2021

--width is confusing at the moment. What it does is more like --max-width.

In a previous version, vcsi generated contact sheets of the exact width specified with --width, however there was an issue which was fixed in #50 by slightly changing the behavior of --width so that it acts as a maximum width that should not be exceeded.

Agreed, this is confusing and should be changed. I may add the previous functionality back into vcsi as an option at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants