Copy with JSON logs is overlapping

[amir20]

          Oops more bugs when testing JSON...

Originally posted by @amir20 in #2572 (comment)

[amir20]

@akash-ramaswamy created this bug to continue discussion. Let's bring all related bugs you find here.

[akash-ramaswamy]

Hi @amir20 , regarding this JSON bug keeping the parent div (which wraps timestamp, stdout/stderr, JSON and copy button) if set to w-full it resolves this bug.

[akash-ramaswamy]

Hi @amir20 , regarding this comment #2572 (comment) this is fine. I was initially thinking this too!

I thought we also could add word-break to the log message div, as it could break into new line automatically and width is maintained!

[amir20]

Send a pr and I'll test it. I have a complicated set up so can test edge cases.

[akash-ramaswamy]

@amir20 raised a PR

[amir20]

Merged the other PR. So looks like search is just remaining.

[amir20]

Tested #2580. Looks good!

[akash-ramaswamy]

Merged the other PR. So looks like search is just remaining.

I have a query though, If we move the search icon to right, how would a user choose Jump to Context if the search entry is at the top?

[amir20]

I think it would be fine since the user can scroll. But I guess it will be one of those things I'll have to test out to really know.

[akash-ramaswamy]

I think it would be fine since the user can scroll. But I guess it will be one of those things I'll have to test out to really know.

But the image I highlighted is the First Log entry 🥶

[amir20]

Maybe for now it will be ok since selecting only the first log won't be common.

We can release a new version and see what others say. If it's a common bug then we can move it or do something else.

[amir20]

If you can get the PR today then I'll try to release.

[amir20]

Releasing now. The only weird bug I saw was that sometimes when clicking to show context, the yellow line would go away. But honestly, I think this is good enough. Generally, after release, I get so many updates that if someone has a bug they will let you know. I am going to close this. Great job!

[akash-ramaswamy]

Hi @amir20 ! I will check that bug you mentioned and let you know!