Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Replay masking does not mask input placeholders #887

Open
GxDesign opened this issue Sep 26, 2024 · 2 comments
Open

Session Replay masking does not mask input placeholders #887

GxDesign opened this issue Sep 26, 2024 · 2 comments
Labels
bug Something isn't working sessionreplay

Comments

@GxDesign
Copy link

GxDesign commented Sep 26, 2024

Expected Behavior

All text displayed in an input should be masked if using conservative or amp-mask class

Current Behavior

Placeholder text is not masked. This is an issue for searchable dropdown components which may update the placeholder value to the selected option.

Steps to Reproduce

  1. create an input with placeholder text and apply amp-mask

Environment

  • "@amplitude/session-replay-browser": "1.13.9"
  • "react": "17.0.2",
@GxDesign GxDesign added the bug Something isn't working label Sep 26, 2024
@lewgordon-amplitude
Copy link

Seems reasonable. We have an internal ticket to track this. We'll update this Github ticket accordingly. Thanks for the feedback!

@lewgordon-amplitude
Copy link

Hey @GxDesign as I was going through the implementation, which I'd like to get merged upstream I saw this issue being raised for rrweb. If it gets accepted we'll pick up the upstream change. If it gets rejected I may go ahead with my implementation. Hope that helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sessionreplay
Projects
None yet
Development

No branches or pull requests

2 participants