Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have flagName back in the cached experiments #19

Closed
sod opened this issue Jun 28, 2023 · 2 comments
Closed

have flagName back in the cached experiments #19

sod opened this issue Jun 28, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@sod
Copy link

sod commented Jun 28, 2023

We use the contents of client.cache.getAll() to render a helper page for QA to assign themself to tests
CleanShot 2023-06-28 at 09 02 10@2x

We use variants, flagKey and flagName. But flagName disappeared in 1.4.0, nowhere to be found in a cache entry:

CleanShot 2023-06-28 at 09 03 53@2x

Could we have flagName back? I could use the amplitude API to fetch them instead, but was kinda nice to not have to bother amplitude servers with extra requests to get to the flag data.

I'd understand if it was out of scope though, as the server has no need for the name.

@sod sod added the enhancement New feature or request label Jun 28, 2023
@bgiori
Copy link
Collaborator

bgiori commented Jul 7, 2023

Hi @sod,

Unfortunately we're not going to add the name back to the response, as it's not useful for evaluation, which is the primary purpose of this SDK.

I'd recommend you use the management API instead.

@bgiori bgiori closed this as completed Jul 7, 2023
@sod
Copy link
Author

sod commented Jul 7, 2023

Will do. Thanks for the answer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants