From 8d81531d3f24168c4af39f0b3df96d4c89f5e534 Mon Sep 17 00:00:00 2001 From: Josh Slaughter <8338893+jdslaugh@users.noreply.github.com> Date: Mon, 14 Oct 2024 15:29:35 -0700 Subject: [PATCH] Adding type to button to fix eslint error Signed-off-by: Josh Slaughter <8338893+jdslaugh@users.noreply.github.com> --- frontend/amundsen_application/static/.betterer.results | 9 ++++----- .../static/js/features/Tags/TagInput/index.tsx | 1 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/frontend/amundsen_application/static/.betterer.results b/frontend/amundsen_application/static/.betterer.results index b2220adca5..f57dd73b11 100644 --- a/frontend/amundsen_application/static/.betterer.results +++ b/frontend/amundsen_application/static/.betterer.results @@ -13,8 +13,8 @@ exports[`eslint`] = { [83, 6, 13, "Do not use setState in componentDidUpdate", "57229240"], [101, 6, 13, "Do not use setState in componentDidUpdate", "57229240"] ], - "js/components/OwnerEditor/index.tsx:2385247435": [ - [85, 6, 13, "Do not use setState in componentDidUpdate", "57229240"] + "js/components/OwnerEditor/index.tsx:2842129076": [ + [88, 6, 13, "Do not use setState in componentDidUpdate", "57229240"] ], "js/components/Preloader/index.tsx:958787996": [ [22, 4, 26, "Must use destructuring props assignment", "1492876559"], @@ -76,14 +76,13 @@ exports[`eslint`] = { "js/features/SearchBar/index.tsx:2560837631": [ [84, 2, 51, "refToSelf should be placed before constructor", "3412474606"] ], - "js/features/Tags/TagInput/index.tsx:914140200": [ + "js/features/Tags/TagInput/index.tsx:896029978": [ [107, 19, 2, "Array.prototype.map() expects a return value from arrow function.", "5859494"], [172, 2, 801, "onChange should be placed before noOptionsMessage", "331725852"], [186, 8, 21, "Must use destructuring props assignment", "2890513821"], [190, 6, 21, "Must use destructuring props assignment", "2890513821"], [238, 8, 118, "Visible, non-interactive elements with click handlers must have at least one keyboard listener.", "3772713652"], - [238, 8, 118, "Static HTML elements with event handlers require a role.", "3772713652"], - [310, 10, 203, "Missing an explicit type attribute for button", "893477908"] + [238, 8, 118, "Static HTML elements with event handlers require a role.", "3772713652"] ], "js/pages/DashboardPage/ChartList/index.tsx:305174342": [ [11, 0, 446, "Component should be written as a pure function", "2708651446"] diff --git a/frontend/amundsen_application/static/js/features/Tags/TagInput/index.tsx b/frontend/amundsen_application/static/js/features/Tags/TagInput/index.tsx index 75417b9f14..0939421a75 100644 --- a/frontend/amundsen_application/static/js/features/Tags/TagInput/index.tsx +++ b/frontend/amundsen_application/static/js/features/Tags/TagInput/index.tsx @@ -312,6 +312,7 @@ export class TagInput extends React.Component { className="btn btn-default muted add-btn" onClick={this.startEditing} title="New" + type="button" > New